[llvm-commits] [patch] Expose RTLIB/float-softening to targets

[Renato Golin]

Hi Tim,

A few questions...

+  return TLI.makeLibCall(DAG, GetFPLibCall(N->getValueType(0),
+                                           RTLIB::ADD_F32,
+                                           RTLIB::ADD_F64,
+                                           RTLIB::ADD_F80,
+                                           RTLIB::ADD_PPCF128),
+                         NVT, Ops, 2, false, N->getDebugLoc());

Shouldn't this (and all other variations) also take into account the IEEE
variation of long doubles?

As far as I can tell (I'm not a diff engine), the main move
was softenSetCCOperands() and makeLibCall() going to TargetLowering. Your
description doesn't tell why this is necessary at all and it's hard to
point it out from the diff, since they're in different files and everything
appears different, but look similar enough.

If the move was just good, not necessary, it'd be easier to have it in two
changes: one with the real change (with a small diff) and another with the
code move (for the sake of simplicity and code organization).

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130108/1543299c/attachment.html>