[llvm-commits] [llvm] r171695 - /llvm/trunk/lib/TableGen/TGParser.cpp

Craig Topper craig.topper at gmail.com
Sun Jan 6 21:23:50 PST 2013


Funny you should ask. I already started on doing that for x86.

On Sun, Jan 6, 2013 at 9:17 PM, Sean Silva <silvas at purdue.edu> wrote:

> Would you be willing to clean up all the other uses of this construct
> in the .td files (also for def's) and then remove support for the
> deprecated syntax altogether?
>
> -- Sean Silva
>
> On Mon, Jan 7, 2013 at 12:09 AM, Craig Topper <craig.topper at gmail.com>
> wrote:
> > Author: ctopper
> > Date: Sun Jan  6 23:09:33 2013
> > New Revision: 171695
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171695&view=rev
> > Log:
> > Revert r171140. We don't actually need to support #NAME. Because NAME by
> itself is interpreted just fine.
> >
> > Modified:
> >     llvm/trunk/lib/TableGen/TGParser.cpp
> >
> > Modified: llvm/trunk/lib/TableGen/TGParser.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.cpp?rev=171695&r1=171694&r2=171695&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/TableGen/TGParser.cpp (original)
> > +++ llvm/trunk/lib/TableGen/TGParser.cpp Sun Jan  6 23:09:33 2013
> > @@ -2406,11 +2406,7 @@
> >
> >    Init *DefmPrefix = 0;
> >
> > -  Lex.Lex(); // eat the defm.
> > -
> > -  // Note that tgtok::paste is here to allow starting with #NAME.
> > -  if (Lex.getCode() == tgtok::Id ||
> > -      Lex.getCode() == tgtok::paste) {
> > +  if (Lex.Lex() == tgtok::Id) {  // eat the defm.
> >      DefmPrefix = ParseObjectName(CurMultiClass);
> >    }
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130106/c8b35cba/attachment.html>


More information about the llvm-commits mailing list