[llvm-commits] [dragonegg] r171641 - /dragonegg/trunk/src/Backend.cpp

[Duncan Sands]

Hi Chandler,

On 06/01/13 00:41, Chandler Carruth wrote:
> On Sat, Jan 5, 2013 at 3:30 PM, Duncan Sands <baldrick at free.fr
> <mailto:baldrick at free.fr>> wrote:
>
>     Author: baldrick
>     Date: Sat Jan  5 17:30:40 2013
>     New Revision: 171641
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=171641&view=rev
>     Log:
>     After Chandler's latest changes, having TTI seems to have become obligatory
>     (otherwise you can get a crash in SelectionDAG.cpp:3392, in the second of the
>     following two lines:
>        const TargetTransformInfo *TTI = DAG.getTargetTransformInfo();
>        if (TTI->getIntImmCost(Val, VT.getTypeForEVT(*DAG.getContext())) < 2)
>     )
>
>
> Yea, this is what I thought it was, but there were other candidates as well.
>
> This will all go away when I finish making it a *real* analysis, and then it
> will be optional, but without it you'll get poor behavior from LSR / vectorizer
> / popcnt recognizer / etc...

at SelectionDAG.cpp:3392 it looks like it should just check whether TTI is null
or not before using it.  Shall I add that check?

Ciao, Duncan.