[llvm-commits] patch: don't sink call address below store

Nick Lewycky nicholas at mxc.ca
Sat Jan 5 10:37:35 PST 2013


The attached patch fixes PR14739. It's not clear to me that this fix is 
actually the right fix as opposed to just covering up the bug for the 
one testcase I've got -- the function introducing the miscompile 
deliberately ignores the (correct) chain information and decides it 
knows better. That seems awfully dubious, but many tests fail if I try 
to just delete it outright.

I also don't know the SDNode hierarchy well enough to know if I could 
make this test smarter, such as by checking for "isa<LoadSDNode>" instead.

Please review!

Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr14739-1.patch
Type: text/x-diff
Size: 2216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130105/58a57eba/attachment.patch>


More information about the llvm-commits mailing list