[llvm-commits] [PATCH] Re-introduce llvm::sys::getHostTriple() function.

Peter Collingbourne peter at pcc.me.uk
Fri Jan 4 12:00:33 PST 2013


On Wed, Jan 02, 2013 at 02:10:57PM -0800, Andy Kaylor wrote:
> 
>   I think the main issue with JIT/MCJIT and the target vs. host triple is with the cross-building buildbots.  There probably are no real world cases where the target triple won't be what the user wants (user error aside), but a couple of the buildbots have problems with incompatible host and target.  Ideally, those buildbots should be configured to not enable JIT, but right now I believe a couple of them aren't.

I already mentioned such a real-world case -- the 32-on-64 bit build.
I think it's sensible to keep JIT on when configured for cross
compiling by default to verify that the JIT continues to work in
this configuration.

>   I also think the changes the the MCJIT execution engine tests and associated lit.cfg file obscure where the triple is coming from in most cases (without actually changing the existing behavior as far as I can tell).

Previously the triple came from the default target triple, but now
it comes from getHostTriple() in most cases.  I'll add a comment to
lit.cfg to state where the triple is coming from.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list