[llvm-commits] [PATCH] PowerPC: Fix eh_frame relocation for PIC

Adhemerval Zanella azanella at linux.vnet.ibm.com
Fri Jan 4 11:10:32 PST 2013


On 01/02/2013 06:04 PM, Hal Finkel wrote:
> ----- Original Message -----
>> From: "Adhemerval Zanella" <azanella at linux.vnet.ibm.com>
>> To: llvm-commits at cs.uiuc.edu
>> Sent: Wednesday, January 2, 2013 7:21:36 AM
>> Subject: [llvm-commits] [PATCH] PowerPC: Fix eh_frame relocation for PIC
>>
>> This patch fixes the PPC eh_frame definitions for the personality and
>> frame unwinding for PIC objects. It makes PIC build correctly creates
>> relative relocations in the '.rela.eh_frame' segments and thus
>> avoiding
>> a text relocation that generates a DT_TEXTREL segments in link phase.
>>
>> Any tips, comments, advices?
> Looks fine to me. Is there a reason why all of the comments start with ';;' instead of just one semicolon?
>
>  -Hal

I'd have to ask Uli, since he was the one who created this testcase, but I
presume there is no specific reason and then I removed the double semicolon.
Pushed as r171506.




More information about the llvm-commits mailing list