[llvm-commits] [llvm] r171475 - in /llvm/trunk/lib: CodeGen/MachineModuleInfo.cpp MC/MCObjectStreamer.cpp MC/MCStreamer.cpp

[Chandler Carruth]

On Fri, Jan 4, 2013 at 10:04 AM, Pedro Artigas <partigas at apple.com> wrote:

> Author: partigas
> Date: Fri Jan  4 12:04:42 2013
> New Revision: 171475
>
> URL: http://llvm.org/viewvc/llvm-project?rev=171475&view=rev
> Log:
> small fixes to enable the reuse of the pass manager across multiple modules
>

Cool!

As you keep finding issues here, I think it would be really good to add
some regression tests. I see two ways of doing it:

1) Write unittests in llvm/unittests/... that spin up an LLVMContext and
pass manager and run N boring modules through it.

2) Add support to 'opt' to run N modules (maybe N files) through a single
LLVMContext and pass manager.


While #1 seems slightly cleaner to me (it would let you more accurately
reproduce bugs found with other uses of the LLVM pass manager libraries in
general, it doesn't matter much, and both seem fine.

Hopefully that way these bugs will stay fixed. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130104/e46f9133/attachment.html>