[llvm-commits] [PATCH] PPC32: Add mapping for darwin/gas modifier in elf object writer

[Hal Finkel]

----- Original Message -----
> From: "Kai" <kai at redstar.de>
> To: llvm-commits at cs.uiuc.edu
> Sent: Sunday, December 30, 2012 5:49:04 PM
> Subject: [llvm-commits] [PATCH] PPC32: Add mapping for darwin/gas modifier in elf object writer
> 
> Hi!
> 
> The VK_PPC_DARWIN_HA16/LO16 and :VK_PPC_GAS_HA16/LO16 modifier are
> not
> mapped in PPCELFObjectWriter.cpp. They should be mapped to
> R_PPC_ADDR16_HA and R_PPC_ADDR16_LO. The attached patch adds these
> mappings.

Kai,

The patch looks fine; I'd prefer that we have a test case. I think that you can make use of the elf-dump utility to generate one; see, for example, test/MC/PowerPC/ppc64-initial-cfa.ll

Thanks again,
Hal

> 
> Regards
> 
> Kai
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory