[llvm-commits] [PATCH 3/3] Test case for readobj sections output. Part of fix for PR14723.

[Sean Silva]

On Thu, Dec 27, 2012 at 5:28 PM, Sami Liedes <sami.liedes at iki.fi> wrote:
> Or should I try to avoid writing a test case that depends on both an
> actual bug fix and changes to a tool to expose that bug?

Why don't you write a test for #2 which doesn't depend on the bug fix.
Once that is committed, submit a patch combining #1+#3.

Nice job doing incremental development btw.

Also, the kernel-style "one patch per message; email message body is
the commit message" isn't the norm on this list. Patches that do that
tend to get lost, because people here don't have setups which handle
it easily; the end result is that your patches won't get reviewed (or
at least, it's a lot less likely). Try to keep all related patches at
least in the same thread, or better yet, all attached to the same
message.

Also, my impression is that sending the commit message as the body of
the email with nothing else added---especially when these are your
first patches (from what I can tell from my email history)---will be
considered a bit "out of the blue" and impersonal. If you make it
clear that these are your first patches to the project, people are
more likely to help you learn the community expectations rather than
silently dropping them from their review queue (for violating
community expectations).

-- Sean Silva