[llvm-commits] [PATCH] Enable -Wdocumentation for LLVM and Clang

[Eric Christopher]

Other than Takumi's comments the patches themselves look fine. No
objections here.

-eric


On Mon, Dec 24, 2012 at 2:07 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> IMO, it would be odd with -Wno-documentation-deprecated-sync.
> Could we clean them up?
>
> ...Takumi
>
> 2012/12/25 Dmitri Gribenko <gribozavr at gmail.com>:
> > Hello,
> >
> > These patches enable -Wdocumentation
> > -Wno-documentation-deprecated-sync for LLVM and Clang.  Please review.
> >
> > Nakamura-san has cleaned up the last documentation warnings, so
> > enabling these flags now does not introduce new warnings during build.
> >
> > Build time difference is 4.4% .. 5.8% (95% confidence interval).
> >
> > Measurements are for configure-based Release+Asserts
> > LLVM+Clang+compiler-rt build on a quad-core Linux desktop with SSD.
> >
> > Dmitri
> >
> > === Raw data and calculations ===
> >
> > Normal build:
> > 12m24s = 744 s
> > 12m16s = 736 s
> > 12m25s = 745 s
> >
> > mean: 741.8 s
> > std dev: 5.0
> > 95% confidence interval: 736.1 s to 747.5 s
> >
> > With -Wdocumentation:
> > 12m58s = 778s
> > 12m59s = 779
> > 13m0s  = 780s
> >
> > mean: 779.0 s
> > std dev: 1
> > 95% confidence interval: 779.1 s to 780.1 s
> >
> > Single core build time difference: 130.4 s .. 172.0 s
> >
> > --
> > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> > (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121224/4e9990bd/attachment.html>