[llvm-commits] [llvm] r169886 - /llvm/trunk/lib/MC/MCAssembler.cpp

Eli Bendersky eliben at google.com
Fri Dec 21 07:56:35 PST 2012


On Fri, Dec 21, 2012 at 7:13 AM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> For example, if fails to build this test on my ASan/Win bot:
> http://code.google.com/p/address-sanitizer/source/browse/trunk/win/tests/malloc_right_oob_crash.cpp
> this also fires up an assertion message box which hangs the bot :(
>
> Is it possible to quick-fix this or revert?

WinCOFFStreamer seems undecided about using the RelaxAll flag. It
overrides MCObjectStreamer's EmitInstruction but does not actually
early-relax instructions in the presence of RelaxAll, so it's not
clear to me why it needs this flag at all. Perhaps there's a bigger
problem hiding here?

Does anyone familiar with this streamer know the answer? Michael?

Also I wonder why there are no regression tests that turn this up.

Eli



More information about the llvm-commits mailing list