[llvm-commits] [PATCH] [msan] Remove unreachable bb's

[Chandler Carruth]

  This still LGTM, but see Dmitri and my style nits. =]


================
Comment at: lib/Transforms/Utils/Local.cpp:988-989
@@ +987,4 @@
+  assert(Reachable.size() < F.size());
+  for (Function::iterator I = llvm::next(F.begin()), E = F.end();
+       I != E; ++I) {
+    if (Reachable.count(I))
----------------
You can probably fit this on a single line now.

================
Comment at: lib/Transforms/Utils/Local.cpp:968
@@ +967,3 @@
+
+/// \\brief - Remove all blocks that can not be reached from the function's
+/// entry.
----------------
Dmitri Gribenko wrote:
> Only a single slash in '\brief'.  Dash is not needed.
Yes, but fix the one in the header file and delete this one. We've switched the coding standards to only suggest comments on the interface when there is a public one in a header file.


http://llvm-reviews.chandlerc.com/D208