[llvm-commits] [compiler-rt] r170429 - in /compiler-rt/trunk/lib/tsan/rtl: tsan_fd.cc tsan_fd.h tsan_interceptors.cc tsan_stat.cc tsan_stat.h

[David Blaikie]

On Wed, Dec 19, 2012 at 12:50 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
> On Wed, Dec 19, 2012 at 12:15 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>> I use both gcc and ToT clang for testing. clang -Wall -Werror does not catch
>>> there errors.
>>
>> See, now that's where I'm confused/this gets interesting. This turned
>> up in a cmake build of llvm ("ninja check-all") without any extra
>> parameters (except to turn on -Werror).
>>
>> I can check the make build too - it's possible this is some mismatch
>> between the two, though I'd be surprised.
>>
>> How exactly are you running your builds?
>
>
>
> $ cd llvm/projects/compiler-rt/lib/tsan
> $ gcc -v | grep version
> gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
> $ clang -v | grep version
> clang version 3.3 (trunk 170311)
> $ make -f Makefile.old presubmit && ../sanitizer_common/scripts/check_lint.sh

This last bit is where I'm confused - why are you using a
separate/different build system from the standard configure or CMake
builds? Supporting/using a 3rd build system is problematic. Developers
not using it are liable to break you, and you are liable to break
other developers using either of the other two.

I guess this may come back to your/Kostya's point that the current
CMake/configure+make build system doesn't do what you need, which is
to compile with the fresh-built Clang? & until that happens you aren't
able to use the standard LLVM project build systems? If that's the
case, then, yes, that really ought to be addressed & now I understand
why it's relevant.

(also, if you want linting as a requirement for the project, please
build that into both the standard build systems as well - otherwise
people are liable to regress it easily)

- David