[llvm-commits] [PATCH] [msan] Heuristic handling of unknown intrinsics

Evgeniy Stepanov eugenis at google.com
Wed Dec 19 00:50:10 PST 2012



================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1327
@@ +1326,3 @@
+    bool WritesMemory = IK == IK_WritesMemory;
+    assert(!(ReadsMemory && WritesMemory));
+
----------------
Kostya Serebryany wrote:
> Can't we ever fail here (e.g. a CAS?)
We can't. I've renamed ReadsMemory to OnlyReadsMemory to make it clear.


http://llvm-reviews.chandlerc.com/D184



More information about the llvm-commits mailing list