[llvm-commits] [PATCH] Disable ARM partial flag dependency optimization at -Oz

[Jim Grosbach]

On Dec 18, 2012, at 11:37 AM, Renato Golin <rengolin at systemcall.org> wrote:

> Hi Quentin,
> 
> This is a good patch, overall 4.4% size reduction. I'm guessing you
> also ran the test-suite and found no errors, though I don't expect too
> many.
> 
> Could you make an early exit if the Oz flag was part of the command
> line arguments, instead of having to find the function's flag on every
> case? Or would that be assuming too much.

The command line options aren't really available here, and we'd have to check for a function-local override anyway, so I don't think that'll work out.

Is there concern here the potential compile time impact? Accessing the attribute list should be pretty quick (a couple of pointer indirections and a bit mask). If we want, we could cache the value locally in the size reduction pass as a local class ivar and initialize it at the start of runOnMachineFunction(). That would make the access a single pointer indirection off the 'this' pointer for the pass.

-Jim

> 
> cheers,
> --renato
> 
> On 18 December 2012 17:21, Quentin Colombet <qcolombet at apple.com> wrote:
>> Ping!
>> 
>> -Quentin
>> 
>> On Dec 17, 2012, at 10:36 AM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>> 
>> Also, here are some code size number.
>> 
>> -Quentin
>> 
>> - {F3245, layout=link}
>> 
>> http://llvm-reviews.chandlerc.com/D219
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> 
> 
> -- 
> cheers,
> --renato
> 
> http://systemcall.org/
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits