[llvm-commits] [PATCH] [ASan] Use dylib interposition to hook memory allocation in the dynamic runtime.

Alexey Samsonov samsonov at google.com
Tue Dec 18 08:24:02 PST 2012


  LGTM


================
Comment at: asan_malloc_mac.cc:89
@@ +88,3 @@
+  if (buflen) {
+    internal_strncpy(new_name.data(), zone_prefix, buflen);
+    internal_strncat(new_name.data(), name, buflen);
----------------
We have internal_snprintf

================
Comment at: asan_malloc_mac.cc:87
@@ +86,3 @@
+  }
+  InternalScopedBuffer<char> new_name(buflen);
+  if (buflen) {
----------------
Will this work for buflen == 0?


http://llvm-reviews.chandlerc.com/D216



More information about the llvm-commits mailing list