[llvm-commits] [PATCH] [msan] Heuristic handling of unknown intrinsics

Kostya Serebryany kcc at google.com
Tue Dec 18 03:49:16 PST 2012


  Looks great!


================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1327
@@ +1326,3 @@
+    bool WritesMemory = IK == IK_WritesMemory;
+    assert(!(ReadsMemory && WritesMemory));
+
----------------
Can't we ever fail here (e.g. a CAS?)


http://llvm-reviews.chandlerc.com/D184



More information about the llvm-commits mailing list