[llvm-commits] addendum to patch for mips16 exception - please review

Bill Wendling wendling at apple.com
Mon Dec 17 01:05:09 PST 2012


Hi Reed,

The patch looks okay to me. Thanks!

-bw

On Dec 16, 2012, at 9:06 AM, Reed Kotler <rkotler at mips.com> wrote:

> I need review before submitting patches outside of the Mips target.
> 
> On my previous patch for mips16 exception handling, I did not add the function body for EmitDebugLabel in MCPureStreamer. This only was caught
> in one of the debian build flavors where a link error in Clang occurred.
> Someone took out the EmitDebugLabel in MCPureStreamer and that fixed the build error but if someone is really using McPureStreamer, then we need to fix this correctly. By just taking out the EmitDebugLabel, that will make EmitDebugLabel from the parent class apply and that would be
> incorrect here.
> 
> See attached patch.
> 
> I think this is safe and is really covered by my initial approval for the mips16 exception patch but I would prefer if someone reviews it.
> <mips16_patch_exception2.txt>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list