[llvm-commits] [llvm] r169791 - in /llvm/trunk: include/llvm/Target/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/Mips/ lib/Target/X86/ test/CodeGen/ARM/ test/CodeGen/X86/

Chris Lattner clattner at apple.com
Thu Dec 13 13:27:27 PST 2012


On Dec 12, 2012, at 10:55 PM, Evan Cheng <evan.cheng at apple.com> wrote:
>>> +  virtual bool isIntImmLegal(const APInt &/*Imm*/, EVT /*VT*/) const {
>>> +    return true;
>>> +  }
>> 
>>> -  virtual bool allowsUnalignedMemoryAccesses(EVT) const {
>>> +  virtual bool allowsUnalignedMemoryAccesses(EVT, bool *Fast = 0) const {
>>>   return false;
>>> }
>> 
>> I know that these shifted around a bit in subsequent patches, but can they take MVTs?  Targets should only have to implement the hooks for legal VTs, not arbitrary LLVM IR types, right?
> 
> Yes this can definitely be moved to MVTs.

Great, please switch them when you get a chance.

-Chris



More information about the llvm-commits mailing list