[llvm-commits] [llvm] r170024 - /llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp

[Hal Finkel]

----- Original Message -----
> From: "Michael Ilseman" <milseman at apple.com>
> To: "NAKAMURA Takumi" <geek4civic at gmail.com>
> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> Sent: Wednesday, December 12, 2012 7:12:47 PM
> Subject: Re: [llvm-commits] [llvm] r170024 - /llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
> 
> 
> On Dec 12, 2012, at 5:02 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> 
> > Michael, it broke self hosting.
> > 
> 
> Do you mean this commit broke it, or that my prior commit broke it
> and this fixed it?

I'm going to guess that this commit broke it. It also broke one of my internal testers. I've attached a short test case that, with this commit, causes instcombine to assert (I apologize, I don't have time to file a PR right now).

 -Hal

> 
> > ...Takumi
> > 
> > 2012/12/13 Michael Ilseman <milseman at apple.com>:
> >> Author: milseman
> >> Date: Wed Dec 12 14:59:36 2012
> >> New Revision: 170024
> >> 
> >> URL: http://llvm.org/viewvc/llvm-project?rev=170024&view=rev
> >> Log:
> >> Restore the PHI optimization I accidently removed
> >> 
> >> Modified:
> >>    llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
> >> 
> >> Modified:
> >> llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp?rev=170024&r1=170023&r2=170024&view=diff
> >> ==============================================================================
> >> --- llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
> >> (original)
> >> +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
> >> Wed Dec 12 14:59:36 2012
> >> @@ -354,6 +354,10 @@
> >>   if (Value *V = SimplifyFAddInst(LHS, RHS, I.getFastMathFlags(),
> >>   TD))
> >>     return ReplaceInstUsesWith(I, V);
> >> 
> >> +  if (isa<PHINode>(LHS))
> >> +    if (Instruction *NV = FoldOpIntoPhi(I))
> >> +      return NV;
> >> +
> >>   // -A + B  -->  B - A
> >>   // -A + -B  -->  -(A + B)
> >>   if (Value *LHSV = dyn_castFNegVal(LHS))
> >> 
> >> 
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug1.ll
Type: application/octet-stream
Size: 3956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121212/0b6f9ab2/attachment.obj>