[llvm-commits] [PATCH] JITEventListener.h: Use llvm-config.h instead of config.h.

[Kaylor, Andrew]

Looks good to me.

-----Original Message-----
From: NAKAMURA Takumi [mailto:geek4civic at gmail.com] 
Sent: Tuesday, December 11, 2012 5:17 PM
To: Kaylor, Andrew; Eric Christopher
Cc: llvm-commits; Eli Bendersky
Subject: Re: [PATCH] JITEventListener.h: Use llvm-config.h instead of config.h.

Ping. I cannot confirm it would work as expected in my site.

2012/12/5 NAKAMURA Takumi <geek4civic at gmail.com>:
> Andy and Eli, could you confirm this in your environments, please?
>
> ...Takumi
>
> 2012/12/5 NAKAMURA Takumi <geek4civic at gmail.com>:
>> A couple of public headers use config.h. One of them is JITEventListener.h.
>>
>> http://llvm.org/bugs/show_bug.cgi?id=7809
>>
>> As discussed in PR7809, we should not include config.h in public headers.
>>
>> ps. The last one is FEnv.h.
>>
>> http://llvm-reviews.chandlerc.com/D171
>>
>> Files:
>>   llvm/include/llvm/Config/llvm-config.h.cmake
>>   llvm/include/llvm/Config/llvm-config.h.in
>>   llvm/include/llvm/ExecutionEngine/JITEventListener.h
>>
>> Index: llvm/include/llvm/Config/llvm-config.h.cmake
>> ===================================================================
>> --- llvm/include/llvm/Config/llvm-config.h.cmake
>> +++ llvm/include/llvm/Config/llvm-config.h.cmake
>> @@ -112,6 +112,12 @@
>>  /* Installation prefix directory */
>>  #cmakedefine LLVM_PREFIX "${LLVM_PREFIX}"
>>
>> +/* Define if we have the Intel JIT API runtime support library */ 
>> +#cmakedefine LLVM_USE_INTEL_JITEVENTS 1
>> +
>> +/* Define if we have the oprofile JIT-support library */ 
>> +#cmakedefine LLVM_USE_OPROFILE 1
>> +
>>  /* Major version of the LLVM API */
>>  #cmakedefine LLVM_VERSION_MAJOR ${LLVM_VERSION_MAJOR}
>>
>> Index: llvm/include/llvm/Config/llvm-config.h.in
>> ===================================================================
>> --- llvm/include/llvm/Config/llvm-config.h.in
>> +++ llvm/include/llvm/Config/llvm-config.h.in
>> @@ -112,6 +112,12 @@
>>  /* Installation prefix directory */
>>  #undef LLVM_PREFIX
>>
>> +/* Define if we have the Intel JIT API runtime support library */ 
>> +#undef LLVM_USE_INTEL_JITEVENTS
>> +
>> +/* Define if we have the oprofile JIT-support library */ #undef 
>> +LLVM_USE_OPROFILE
>> +
>>  /* Major version of the LLVM API */
>>  #undef LLVM_VERSION_MAJOR
>>
>> Index: llvm/include/llvm/ExecutionEngine/JITEventListener.h
>> ===================================================================
>> --- llvm/include/llvm/ExecutionEngine/JITEventListener.h
>> +++ llvm/include/llvm/ExecutionEngine/JITEventListener.h
>> @@ -15,7 +15,7 @@
>>  #ifndef LLVM_EXECUTION_ENGINE_JIT_EVENTLISTENER_H
>>  #define LLVM_EXECUTION_ENGINE_JIT_EVENTLISTENER_H
>>
>> -#include "llvm/Config/config.h"
>> +#include "llvm/Config/llvm-config.h"
>>  #include "llvm/Support/DataTypes.h"
>>  #include "llvm/Support/DebugLoc.h"
>>  #include <vector>