[llvm-commits] [PATCH] Take into account minimize size attribute in the inliner

[Quentin Colombet]

Hi Eric,

Thanks for the review, I'll add a testcase.
Regarding the performance impact, tell me what do you want me to measure/run.

Thanks,

Quentin

Envoyé de mon iPhone

Le 11 déc. 2012 à 17:36, Eric Christopher <echristo at gmail.com> a écrit :

> Seems pretty reasonable, testcase? Performance impact?
> 
> -eric
> 
> 
> On Tue, Dec 11, 2012 at 5:22 PM, Nadav Rotem <nrotem at apple.com> wrote:
>> LGTM. 
>> 
>> On Dec 11, 2012, at 5:20 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>>> Hi,
>>> 
>>> I have attached a patch that better controls the inlining of functions when the caller function has MinSize attribute.
>>> Basically, when the caller function has this attribute, we do not "force" the inlining of callee functions carrying the InlineHint attribute (i.e., functions defined with inline keyword).
>>> 
>>> Thanks for the reviews.
>>>  
>>> -Quentin
>>> <inliner_minisize.patch>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121211/4618cf1c/attachment.html>