[llvm-commits] [LLVMdev] !!! 3.2 Release RC2 deadline November 29th

Akira Hatanaka ahatanak at gmail.com
Mon Dec 3 19:44:00 PST 2012 

OK. Please disregard r169098.

On Mon, Dec 3, 2012 at 5:00 PM, Bill Wendling <wendling at apple.com> wrote:

> On Dec 3, 2012, at 1:53 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:
>
> > Also, I would like to have the following patch merged, if possible:
> >
> > r169098
> >
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121126/068982.html
> >
> > This patch adds mxgot command line options to clang driver.
> >
> Hold on...This adds new functionality. For RC2, we should be accepting
> only *serious* regression fixes. Absolutely no new features should be added
> in at this time.
>
> -bw
>
> > Is it okay to merge this patch (cc'ing Chad who is the code owner of
> this part)?
> >
> > On Fri, Nov 30, 2012 at 10:41 AM, Pawel Wodnicki <pawel at 32bitmicro.com>
> wrote:
> >
> > > It sounds like we're holding off on these, but for the record, r168448
> is fine to go in if we get another window of opportunity.
> >
> > Great, r168448 was the one holding the merge, the rest are MIPS only
> > so any problems would probably affect only MIPS target.
> >
> > Anyway, RC2 went ahead as scheduled but I am sure we will find
> > some issues in testing. So I will do RC3 by middle of next
> > week (Wednesday), this will be a good time to incorporate MIPS patches.
> >
> > In the mean time I guess Akira could continue testing
> > and or refining these changes as necessary. I am not
> > really setup to test MIPS beyond make check-all, unless
> > I dust off my SGI O2 or better re-purpose some wirelesses router :)
> >
> > >I tested the patches, and they shouldn't have any problems.
> >
> > At this point I get a bit uncomfortable with "shouldn't
> > have any problems", I want "Sure, no problem just merge them!".
> > Also, if you have any changes to these patches please allow me
> > 24h for processing, just tell me by Tuesday next week what to merge.
> >
> > Pawel
> >
> >
> > >
> > > -Jim
> > >
> > > On Nov 29, 2012, at 6:49 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > >
> > >> Jim, could you approve r168448, "Add relocations used for mips big
> GOT."?
> > >> llvm/include/llvm/MC/MCExpr.h
> > >> llvm/lib/MC/MCExpr.cpp
> > >>
> > >> Others (lib/Target/Mips) should be owned de-facto by Mips guys, I
> > >> suppose, though.
> > >> I think Evan could approve them in this case.
> > >>
> > >> Pawel, FYI, they, 8 commits, can be applied cleanly into release_32
> > >> and can be built w/o warnings nor failures.
> > >>
> > >> llvm/include/llvm/MC/MCExpr.h                             |    6 +-
> > >> llvm/lib/MC/MCExpr.cpp                                    |    4 +
> > >> llvm/lib/Target/Mips/InstPrinter/MipsInstPrinter.cpp      |    4 +
> > >> llvm/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp      |   10 +-
> > >> llvm/lib/Target/Mips/MCTargetDesc/MipsBaseInfo.h          |    8 +-
> > >> llvm/lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp |   12 +
> > >> llvm/lib/Target/Mips/MCTargetDesc/MipsFixupKinds.h        |   12 +
> > >> llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp   |   12 +
> > >> llvm/lib/Target/Mips/Mips64InstrInfo.td                   |    2 +
> > >> llvm/lib/Target/Mips/MipsISelLowering.cpp                 |  257
> ++++++-------
> > >> llvm/lib/Target/Mips/MipsInstrInfo.td                     |    2 +
> > >> llvm/lib/Target/Mips/MipsMCInstLower.cpp                  |    4 +
> > >> llvm/test/CodeGen/Mips/biggot.ll                          |   50 +++
> > >> llvm/test/MC/Mips/xgot.ll                                 |   42 ++
> > >> 14 files changed, 276 insertions(+), 149 deletions(-)
> > >>
> > >> ...Takumi
> > >>
> > >> 2012/11/30 32bitmicro <root at 32bitmicro.com>:
> > >>> Akira,
> > >>>
> > >>>> Pawel,
> > >>>>
> > >>>> Is it still not too late to merge these patches?
> > >>>>
> > >>>> r168471
> > >>>> r168460
> > >>>> r168458
> > >>>> r168456
> > >>>> r168455
> > >>>> r168453
> > >>>> r168450
> > >>>> r168448
> > >>>>
> > >>>> These patches fix a bug in mips backend's GOT implementation and add
> > >>>> support for big-GOT relocations.
> > >>>
> > >>> That's quite a list of patches! To get them into the
> > >>> 3.2 release you would first need to get approval from all
> > >>> the code owners and then we would have to merge and test.
> > >>> Frankly, I do not see how we could get all that done
> > >>> without delaying the release, RC2 deadline is today
> > >>> at 10p.m. PST.
> > >>>
> > >>> Pawel
> > >>>
> > >>>>
> > >>>> Thank you.
> > >>>>
> > >>>> On Tue, Nov 27, 2012 at 7:35 PM, Pawel Wodnicki <
> root at 32bitmicro.com> wrote:
> > >>>>
> > >>>>> Hello,
> > >>>>>
> > >>>>> Just a quick reminder that the November 29th (10p.m. PST) is the
> > >>>>> end of Phase 1 testing and Release Candidate 2 (RC2) deadline.
> > >>>>> After RC2 deadline, LLVM-Clang 3.2 release will be considered
> feature
> > >>>>> complete and no new functionality can be added.
> > >>>>>
> > >>>>> With 2 days left please use following guidelines when
> > >>>>> initiating request for patches before RC2 deadline.
> > >>>>>
> > >>>>> I will be happy to merge *approved* patches for low risk/
> > >>>>> crash fixes that merge cleanly and have simple test case or
> > >>>>> procedure to verify correctness (aka 1040 EZ Patch).
> > >>>>>
> > >>>>> Patches that do not fall under the above category need to
> > >>>>> be classified as either release blocking (discussed below)
> > >>>>> or non release blocking and thus not included in this release.
> > >>>>>
> > >>>>>
> > >>>>> Code owners
> > >>>>>
> > >>>>> I need your input on the state of the release blocking issues as
> > >>>>> listed in the Bug 13893 - "Umbrella bug for 3.2 release"
> > >>>>>
> > >>>>> http://llvm.org/bugs/show_bug.cgi?id=13893.
> > >>>>>
> > >>>>> Please review the list below and let me know whether the
> > >>>>> listed bugs can be (better yet will be!) fixed in the Phase 2.
> > >>>>>
> > >>>>> If there are other release stopping bugs/issues that you
> > >>>>> think should be fixed before the final 3.2 release but
> > >>>>> are not listed below then please add them to the
> > >>>>> Bug 13893 - "Umbrella bug for 3.2 release".
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> As of today Tuesday Nov 27th following release blocking
> > >>>>> bugs are still open:
> > >>>>>
> > >>>>> 12664 - O2 -ftree-vectorize
> -fplugin-arg-dragonegg-enable-gcc-optzns on
> > >>>>> mdbx.f90 confuses dragoneg
> > >>>>>
> > >>>>> 13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 =
> > >>>>> extract_vector_elt 0x14214b910, 0x142142c10
> > >>>>>
> > >>>>> 14116 - Inliner incorrectly combines cleanup and catch landing pads
> > >>>>>
> > >>>>> 14279 - mishandling of implicit move in class with copy-only member
> > >>>>>
> > >>>>> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when
> returning
> > >>>>> v4f64 on ARM
> > >>>>>
> > >>>>> 14429 - Dragonegg fails to build clang
> > >>>>>
> > >>>>>
> > >>>>> Pawel
> > >>>>> _______________________________________________
> > >>>>> LLVM Developers mailing list
> > >>>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> > >>>>>
> > >>>>
> > >>>
> > >>> _______________________________________________
> > >>> LLVM Developers mailing list
> > >>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> > >
> > >
> > >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121203/c34d98b3/attachment.html>

More information about the llvm-commits mailing list