[llvm-commits] PATCH: FileCheck to allow referencing vars defined on the same line

Dmitri Gribenko gribozavr at gmail.com
Sat Dec 1 13:50:24 PST 2012


On Sat, Dec 1, 2012 at 11:36 PM, Eli Bendersky <eliben at google.com> wrote:
>> This is for existing functionality, but is related to this feature.  I
>> mean something like this:
>>
>> op1 r1, r2, r1
>>
>> ; CHECK: {{([a-z]+[0-9])+}} [[REG:r[0-9]+]], {{r[0-9]+}}, [[REG]]
>>
>> Where we have parentheses inside a regexp.  These should be counted in
>> 'CurParen' correctly so that we get the backreference number right.
>> It was already done before to correctly capture variables, but this
>> feature depends on this, too.
>
> OK, I'm attaching an updated patch that adds this test, as well as the
> other issue you raised (AddBackrefToRegEx method accepting unsigned).

LGTM.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the llvm-commits mailing list