[llvm-commits] [llvm] r168970 - in /llvm/trunk: lib/Transforms/Utils/SimplifyCFG.cpp test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll

[Eli Friedman]

On Thu, Nov 29, 2012 at 6:02 PM, Evan Cheng <evan.cheng at apple.com> wrote:
> Author: evancheng
> Date: Thu Nov 29 20:02:42 2012
> New Revision: 168970
>
> URL: http://llvm.org/viewvc/llvm-project?rev=168970&view=rev
> Log:
> Fix logic to determine whether to turn a switch into a lookup table. When
> the tables cannot fit in registers (i.e. bitmap), do not emit the table
> if it's using an illegal type.
>
> rdar://12779436

Is there some reason we shouldn't emit a table with an illegal type?
Or does it just not work properly given how the code is currently
structured?  It would be nice to have a comment in the code with an
explanation.

-Eli