[llvm-commits] [llvm] r168864 - in /llvm/trunk/lib/Transforms/Instrumentation: AddressSanitizer.cpp ThreadSanitizer.cpp

[Kostya Serebryany]

On Thu, Nov 29, 2012 at 2:08 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Thu, Nov 29, 2012 at 1:54 AM, Kostya Serebryany <kcc at google.com> wrote:
> > @@ -857,6 +861,7 @@
> >    if (BL->isIn(F)) return false;
> >    if (&F == AsanCtorFunction) return false;
> >    DEBUG(dbgs() << "ASAN instrumenting:\n" << F << "\n");
> > +  initializeCallbacks(*F.getParent());
>
> It would probably be worthwhile to add an early exit for empty functions
> here.
>
> You could also (I think) early exit for any function with the readnone
> attribute which has no alloca instructions in its first BB.
>

Yea, maybe.
That's why I liked initializing this stuff in doInitialization -- it didn't
need all these optimizations :)
--kcc



> Of course, it's doubtful any of this will have a terribly significant
> impact on compile time.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121129/06dc479a/attachment.html>