[llvm-commits] [llvm] r168711 - in /llvm/trunk: lib/Analysis/ScalarEvolution.cpp test/Transforms/IndVarSimplify/eliminate-comparison.ll

[David Nadlinger]

On Tue, Nov 27, 2012 at 7:24 PM, Benjamin Kramer <benny.kra at gmail.com> wrote:
>
> On 27.11.2012, at 19:16, Benjamin Kramer <benny.kra at googlemail.com> wrote:
>
>> Author: d0k
>> Date: Tue Nov 27 12:16:32 2012
>> New Revision: 168711
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=168711&view=rev
>> Log:
>> SCEV: Even if the latch terminator is foldable we can't deduce the result of an unrelated condition with it.
>>
>> Fixes PR14432.
>
> Chris, can you approve this for 3.2? It fixes a miscompilation and is apparently a regression from 3.1.

Thanks for the quick fix!

To clarify, this bug isn't specifically a regression from 3.1, but
leads to a 3.2 regression in our (LDC) test suite because changes in
other passes now cause it to be triggered. Thus, if you think the fix
is sufficiently low-risk, we'd love to see it in 3.2.

David