[llvm-commits] Improvements to PassManager

[Pedro Artigas]

Hello All/Chandler,

I believe this patch addresses the issues W.R.T. the FIXME comments you mentioned.
I agree that maybe there are too many FIXMEs it is just that I believed it was better to add everywhere the temporary code is needed than just in the var declaration, hopefully ASAN will get fixed soon and it will all go away.

Thanks

Pedro

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121126/1027f855/attachment.txt>
-------------- next part --------------


On Nov 26, 2012, at 11:30 AM, Chandler Carruth <chandlerc at google.com> wrote:

> On Mon, Nov 26, 2012 at 11:27 AM, Pedro Artigas <partigas at apple.com> wrote:
>> Hello All/Chandler,
>> 
>> The patch below has the corrections on the FIXME comments you suggested.
> 
> I had several other style comments you haven't addressed though...
> 
>> The need for doFinalization inside the runOnModule of the FPPassManager is the very line that makes ASAN work today, that is why it is still there.
> 
> Ok.