[llvm-commits] [PATCH][RFC] Disable data region directives

Jim Grosbach grosbach at apple.com
Mon Nov 26 09:42:51 PST 2012


I did, thank you! I'm now in the process of digging myself out from under the mountain of email. I have this flagged for review already and hope to get to it later today.

-Jim

On Nov 26, 2012, at 8:08 AM, Joe Abbey <jabbey at arxan.com> wrote:

> Hope you had a Happy Thanksgiving!
> 
> Ping,
> 
> Joe
> 
> On Nov 19, 2012, at 11:19 AM, Joe Abbey <jabbey at arxan.com> wrote:
> 
>> Jim,
>> 
>> Could you please review?
>> 
>> Thanks!
>> 
>> Joe
>> 
>> On Nov 17, 2012, at 5:18 PM, Joe Abbey <jabbey at arxan.com> wrote:
>> 
>>> I'm not sure if other assemblers are affected by this... but Apple cctools-807~393 (Xcode 4.4.1) chokes on .data_region pseudo-ops.  Xcode 4.5.2 doesn't seem to have any problems with it.  
>>> 
>>> I propose the following patch to disable data region directive generation:
>>> 
>>>   -disable-data-region-directives         - Disable data region directives which older assemblers reject
>>> 
>>> Looking back to r157062 I see that this should only affect introspection of object files and fully-linked binaries.  However if there are any other side-effects please let me know.
>>> 
>>> Ok to commit?
>>> 
>>> Joe
>>> ______________________________
>>> Joe Abbey
>>> Director of Software Development
>>> Arxan Technologies
>>> jabbey at arxan.com www.arxan.com
>>> Protecting the App Economy™
>>> 
>>> 
>>> <disable-data-region-directives.patch>
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121126/0ffda26d/attachment.html>


More information about the llvm-commits mailing list