[llvm-commits] [llvm] r168321 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[David Blaikie]

On Mon, Nov 19, 2012 at 11:43 AM, Eric Christopher <echristo at gmail.com> wrote:
> Author: echristo
> Date: Mon Nov 19 13:43:59 2012
> New Revision: 168321
>
> URL: http://llvm.org/viewvc/llvm-project?rev=168321&view=rev
> Log:
> Move section label emission to module end. Nothing should be
> depending on them being emitted before the text and/or data
> sections and testing didn't uncover any.

Turns out testing kind of did uncover some. Bisection points to this
change as the cause of the regression of the gdb test suite
gdb.cp/hang.exp test case.
* logs: http://lab.llvm.org:8011/builders/clang-x86_64-darwin10-gdb/builds/39/steps/test-gdb-1472-testsuite/logs/gdb.log
* Specific failures:
http://lab.llvm.org:8011/builders/clang-x86_64-darwin10-gdb/builds/37/steps/test-gdb-1472-testsuite/logs/tests.FAIL
* source exp: http://llvm.org/viewvc/llvm-project/clang-tests-external/trunk/gdb/7.5/gdb/testsuite/gdb.cp/hang.exp?view=markup

I can dig into this further if you like, but thought you might see
what's going on here at a glance.

- David

>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=168321&r1=168320&r2=168321&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Nov 19 13:43:59 2012
> @@ -791,9 +791,6 @@
>    // Tell MMI that we have debug info.
>    MMI->setDebugInfoAvailability(true);
>
> -  // Emit initial sections.
> -  EmitSectionLabels();
> -
>    // Prime section data.
>    SectionMap.insert(Asm->getObjFileLowering().getTextSection());
>  }
> @@ -876,6 +873,9 @@
>    // Compute DIE offsets and sizes.
>    computeSizeAndOffsets();
>
> +  // Emit initial sections.
> +  EmitSectionLabels();
> +
>    // Emit all the DIEs into a debug info section
>    emitDebugInfo();
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits