[llvm-commits] [llvm] r168181 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/icmp.ll

NAKAMURA Takumi geek4civic at gmail.com
Thu Nov 22 15:15:15 PST 2012


2012/11/23 Pawel Wodnicki <pawel at 32bitmicro.com>:
>  As for your original request, from the release process perspective:
>
>  I should be getting and processing requests approved
> by code owners only :)

I am sorry that I asked you directly. I understand it would not be my business.

Instead, I shall let you know if you picked up incomplete commits to
break the release build.
I am certain to be one of testers (aka watchers) on the release.
(Did you know you didn't apply clang r168297 cleanly and it caused
failure in clang/test/Driver/pic.c?)

>  I do no think merging partial patches into the release branch
> should be the way we deal with issues unless there is no other
> way the to fix a problem.

I proposed minimal fix. r168196 is "similar simplification without any
dependence each other."
To be more consistent, I might suggest "both r168186 and r168196".
They could be applied cleanly on the release_32.


...Takumi



More information about the llvm-commits mailing list