[llvm-commits] [PATCH] Convert SourceLevelDebugging.html to reST

Dmitri Gribenko gribozavr at gmail.com
Wed Nov 21 13:03:49 PST 2012


On Wed, Nov 21, 2012 at 10:56 PM, Eli Bendersky <eliben at google.com> wrote:
> Some comments:

Thanks for reviewing!

> * In the "subprogram descriptors" section, the code is not
> highlighted. Also in other places. Not sure how important highlighting
> is here, but it would be nice to make it consistent

The code block is marked as '.. code-block:: llvm', but this line:

> Function * , ;; Pointer to LLVM function

seems to confuse the highlighter.  If I remove it, highlighting works.
 (But obviously, removing the line is not an option.)  There are
similar issues in other places.

> * In the original HTML, LLVMDebugVersion in the metadata listings was
> linking to a paragraph explaining it. This is probably not very
> important, but nice to have. Is there a simple way to reproduce this
> effect in the ReST doc?

Unfortunately, I don't think it is possible.  Maybe Sean could give an advice?

> * When the HTML version mensions the intrinsics (i.e.
> llvm.dbg.declare), they are links. Not in ReST

Same here -- as far as I know, it is not possible to have a link in
fixed width font...

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the llvm-commits mailing list