[llvm-commits] [llvm] r168451 - /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td

[Jyotsna Verma]

Thanks Dmitri for pointing it out. I will fix the comments to use the same names as the definitions.

-Jyotsna

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


> -----Original Message-----
> From: Dmitri Gribenko [mailto:gribozavr at gmail.com]
> Sent: Wednesday, November 21, 2012 2:30 PM
> To: Jyotsna Verma
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [llvm] r168451 -
> /llvm/trunk/lib/Target/Hexagon/HexagonOperands.td
> 
> On Wed, Nov 21, 2012 at 10:05 PM, Jyotsna Verma
> <jverma at codeaurora.org> wrote:
> > +def Clr3ImmPred : PatLeaf<(i32 imm), [{
> > +  // Clr4ImmPred predicate - True if the number is in the series of
> 
> Hi Jyotsna,
> 
> Name in 'def' does not match the name in comment.  Should it?  (And there
> are quite a few such inconsistencies in this commit.)  If it should be the same,
> please consider dropping the name from the comment altogether since it
> contributes no value to the reader -- there's the same name on the previous
> line.  (Unless you rely on this comment being copied verbatim to the
> generated C++ code for readability.)
> 
> Dmitri
> 
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/