[llvm-commits] [PATCH][Hexagon] Clean immediate operand defintions

[Jyotsna Verma]

I guess this comment has stayed in for long enough. Now, we must let it go.
:)

Thanks,
Jyotsna

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


> -----Original Message-----
> From: Sean Silva [mailto:silvas at purdue.edu]
> Sent: Wednesday, November 21, 2012 11:12 AM
> To: Jyotsna Verma
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH][Hexagon] Clean immediate operand
> defintions
> 
> I was just about to ask for this on seeing the other commit :)
> 
> -  // For now, we use a generic print function for all operands.
> -  let PrintMethod = "printNOneImmOperand"; [...]
> +// Immediate operands.
> +
> +let PrintMethod = "printImmOperand" in {
> 
> you might want to preserve that "For now" comment.
> 
> -- Sean Silva
> 
> On Wed, Nov 21, 2012 at 11:46 AM, Jyotsna Verma
> <jverma at codeaurora.org> wrote:
> > The attached patch changes the Hexagon specific immediate operand
> > definitions to use one common let expression for PrintMethod. Please
> > let me know if the patch is good to commit.