[llvm-commits] [llvm] r168197 - in /llvm/trunk: lib/AsmParser/LLParser.cpp test/Assembler/global-addrspace-forwardref.ll

[Pawel Wodnicki]

> 
> On Nov 19, 2012, at 5:29 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> 
>> FYI, it is essential to unbreak r168336 in release_32.
>>
>> http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/1113
> 
> Yes, I approve.

Committed revision 168435.

> 
> -Chris
> 
>>
>>
>> 2012/11/20 Justin Holewinski <justin.holewinski at gmail.com>:
>>> Chris,
>>>
>>> I believe you are still the code owner of the assembly parser.  Do you
>>> approve of this patch going into 3.2?
>>>
>>>
>>> On Mon, Nov 19, 2012 at 5:38 PM, Pawel Wodnicki <pawel at 32bitmicro.com>
>>> wrote:
>>>>
>>>> Justin,
>>>>
>>>>
>>>>> With all the activity around code owners recently, I figured it would be
>>>>> best to just put it on the commits list and let whoever wants to own
>>>>> that
>>>>> piece speak up.
>>>>>
>>>>
>>>> What's the status of r168197?
>>>> Have you found the owner?
>>>> Pawel
>>>>
>>>>>
>>>>> On Fri, Nov 16, 2012 at 8:03 PM, Eli Friedman
>>>>> <eli.friedman at gmail.com>wrote:
>>>>>
>>>>>> On Fri, Nov 16, 2012 at 4:46 PM, Justin Holewinski
>>>>>> <justin.holewinski at gmail.com> wrote:
>>>>>>> Pawel,
>>>>>>>
>>>>>>> Can we get this merged into 3.2?  I'm not sure who the code owner for
>>>>>> the LL
>>>>>>> parser is.
>>>>>>
>>>>>> You're supposed to ask the code-owner before dragging the release
>>>>>> manager into the discussion.
>>>>>>
>>>>>> By default, the owner here is Chris.  We should probably get someone
>>>>>> else to own lib/AsmParser/, though...
>>>>>>
>>>>>> -Eli
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Thanks,
>>>
>>> Justin Holewinski
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
> 
> 
>