[llvm-commits] [zorg] r168404 - /zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py

[David Blaikie]

Author: dblaikie
Date: Tue Nov 20 18:46:04 2012
New Revision: 168404

URL: http://llvm.org/viewvc/llvm-project?rev=168404&view=rev
Log:
Fail clang tests if the test command fails.

This can happen when no errors are logged if lit itself failed & did not log
anything in the process. (I've witnessed this on private/experimental bots
which suffered from a python bug/missing dependency)

Modified:
    zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py

Modified: zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py?rev=168404&r1=168403&r2=168404&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py (original)
+++ zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py Tue Nov 20 18:46:04 2012
@@ -17,7 +17,6 @@
   kMaxFailureLogs = 20
 
   def evaluateCommand(self, cmd):
-    rc = 0
     grouped = {}
     failureLogs = []
     lines = self.getLog('stdio').readlines()
@@ -73,6 +72,4 @@
                         failed=numFail + numXPass + numUnresolved,
                         passed=numPass + numXFail,
                         warnings=numXFail)
-    if numFail + numXPass + numUnresolved:
-      return buildbot.status.builder.FAILURE
-    return buildbot.status.builder.SUCCESS
+    return buildbot.steps.shell.Test.evaluateCommand(self, cmd)