[llvm-commits] [PATCH] adding the -no-show-raw-insn option to llvm-objdump

[Eric Christopher]

On Mon, Nov 19, 2012 at 4:40 PM, Eli Bendersky <eliben at google.com> wrote:

> Hi All,
>
> I'm attaching a patch for llvm-objdump which adds the
> -no-show-raw-insn option from objdump (do not print the raw
> instruction encoding when disassembling). Please take a look.
>
> The patch itself is pretty simple but it raises an interesting concern
> about the lack of tests targeted at llvm-objdump (and possibly other
> tools we have). I assume there won't be much disagreement on whether
> we should have tests for the tools at all, but where should we put
> them? AFAICS, test/tools does not exist. Should it be added?
>

Can, I don't really have an objection. For my uses I've been largely adding
them in the area for things they're designed to test, but in this case
you're testing the tool itself so that sounds good to me. Other option is
test/Object and start adding tests with input there.

I'm neutral on which one I'd prefer so it's up to you.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121120/a2d8d0db/attachment.html>