[llvm-commits] [PATCH] YAMLParser diagnostics filename

Michael Spencer bigcheesegs at gmail.com
Mon Nov 19 11:45:22 PST 2012


On Mon, Nov 19, 2012 at 11:33 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> On Mon, Nov 19, 2012 at 8:32 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>>
>> Hopefully the comments in the updated patch make sense, can you commit if so?
>
> Ahem. Patch attached.
>
> - K

+  /// @brief This makes a copy of \a Input.

This is not accurate. Input is copied by value, but this comment
implies that the string that Input references is copied. This should
state that Stream keeps a reference to the string.

- Michael Spencer




More information about the llvm-commits mailing list