[llvm-commits] [PATCH] YAMLParser diagnostics filename

Kim Gräsman kim.grasman at gmail.com
Mon Nov 19 11:32:31 PST 2012


Hi Michael,

On Mon, Nov 19, 2012 at 12:17 AM,  <bigcheesegs at gmail.com> wrote:
>
> You need to document the ownership semantics of the MemoryBuffer pointer (SourceMgr takes ownership).
> See llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments for how to document.
> Other than that it looks good.

Thanks! I don't know Doxygen very well -- the comments in YAMLParser
use a different syntax from the doc you linked (@brief instead of
\brief) -- so I tried to mimic the surrounding code.

Hopefully the comments in the updated patch make sense, can you commit if so?

- Kim



More information about the llvm-commits mailing list