[llvm-commits] [PATCH] python binding: add set_options for Disassembler

[Gregory Szorc]

On 11/8/2012 9:11 AM, Wladimir wrote:
> Hello,
>
> This patch adds support for set_options to the Python binding to the 
> disassembler. This allows using markup. A nose testcase for the new 
> functionality is also added.
>
> The patch should apply cleanly to latest SVN trunk.
>

This looks good to me. If anything, I would do something with the return 
value from LLVMSetDisasmOptions. I'd either convert it to a bool to 
indicate success or raise if we see a 0. Silently failing isn't optimal. 
Do you agree?