[llvm-commits] [llvm] r168074 - /llvm/trunk/lib/CodeGen/StackColoring.cpp

Jakob Stoklund Olesen stoklund at 2pi.dk
Fri Nov 16 08:18:43 PST 2012


On Nov 16, 2012, at 5:49 AM, Ulrich Weigand <ulrich.weigand at de.ibm.com> wrote:
> the difficulty I see with using array_pod_sort or something else
> based on qsort is that those just use a plain function as compare
> routine, while std::sort uses a function object ... which is used
> here to hold the "MFI" parameter needed to implement the comparison.

You are right, of course.

> I certainly agree that the ordering can easily be made total;
> I could implement this by changing SlotSizeSorter so we can continue
> to use std::sort instead of std::stable_sort.  Would this be
> preferable?

Either way is fine by be.

/jakob





More information about the llvm-commits mailing list