[llvm-commits] [llvm] r167719 - /llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h

[Justin Holewinski]

I'm responsible for both the original cause of the warning (oops!) and code
ownership on this backend.  Though I took on that responsibility after the
branch, so I'm not sure what the procedure is for that. :)

As far as I'm concerned, it should definitely go into the 3.2 branch.
 Pawel, I also have a list of a few other NVPTX bug fixes I would like
pushed into the 3.2 branch before the next RC.  I'll send the list in a bit.


On Fri, Nov 16, 2012 at 9:51 AM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> I think Justin may be responsible.
>
> FYI, it should fix a warning.
>
> http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/1069
>
>
> /home/bb/clang-3stage-x86_64-linux/llvm-project/llvm/lib/Target/NVPTX/NVPTXSubtarget.h:31:8:
> warning: private field 'dummy' is not used [-Wunused-private-field]
> 1 warning generated.
>
>
> 2012/11/16 Pawel Wodnicki <pawel at 32bitmicro.com>:
> > Evan,
> > It is a small change but after branching I
> > need code owner to approve it.
> >
> > Pawel
> >
> >> Pawel, Please pull it into release_32.
> >>
> >> ...Takumi
> >>
> >> 2012/11/12 Eric Christopher <echristo at gmail.com>:
> >>> Author: echristo
> >>> Date: Mon Nov 12 01:35:12 2012
> >>> New Revision: 167719
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=167719&view=rev
> >>> Log:
> >>> Remove unused field.
> >>>
> >>> Modified:
> >>>     llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h
> >>>
> >>> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h
> >>> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h?rev=167719&r1=167718&r2=167719&view=diff
> >>>
> ==============================================================================
> >>> --- llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h (original)
> >>> +++ llvm/trunk/lib/Target/NVPTX/NVPTXSubtarget.h Mon Nov 12 01:35:12
> 2012
> >>> @@ -28,7 +28,6 @@
> >>>
> >>>    std::string TargetName;
> >>>    NVPTX::DrvInterface drvInterface;
> >>> -  bool dummy; // For the 'dummy' feature, see NVPTX.td
> >>>    bool Is64Bit;
> >>>
> >>>    // PTX version x.y is represented as 10*x+y, e.g. 3.1 == 31
> >>>
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>
> >>
> >
>



-- 

Thanks,

Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121116/8c0f9207/attachment.html>