[llvm-commits] [PATCH, PowerPC] Fix MC instruction encodings

Chandler Carruth chandlerc at google.com
Tue Nov 13 12:08:11 PST 2012


On Tue, Nov 13, 2012 at 11:23 AM, Ulrich Weigand
<Ulrich.Weigand at de.ibm.com> wrote:
> Hal Finkel <hfinkel at anl.gov> wrote on 13.11.2012 20:01:08:
>
>> LGTM. We should add test cases (but I think that we can't do that
>> until we have the asm parser working, and that's blocked by TableGen
>> problems), so those can wait.
>
> Checked in as revisions 167860..167863.
>
> Agree on the test cases ...

FWIW, I don't think this is a good strategy. It is *essential* that we
prioritize all of the efforts necessary to fix the underlying
infrastructure first, so that we can build up a proper regression test
suite each time these types of encoding fixes go into the tree.

I would ask that folks who care about PPC focus their efforts on
resolving these underlying issues first, and then come back to
encoding bugs.



More information about the llvm-commits mailing list