[llvm-commits] ARM ELF disassembly with integrated-as

[Tim Northover]

Hi Greg,

> But since you have provided clear
> direction on implementation, I'd be happy to give it a shot.

Cheers.

> There is no test for checking for duplicates.  I don't know how to do that
> with FileCheck.  Is there a way or would I need another tool?

I think CHECK-NOT is probably your friend. If you know a module should
produce (say) only one $a then test-lines like:

CHECK: $a
CHECK-NOT: $a

should make sure there aren't any extra. Even if a valid
implementation could change that number, it'll at least make the next
person who comes along to modify this code think about the issue.

> > Wouldn't you need two functions to force the Streamer to
> > ChangeSection to .text twice?

> I don't understand.  Can you clarify?

This was just my guess at the kind of code that made you decide to put
that deduplication code in.

Tim.