[llvm-commits] [PATCH] instcombine: wire up -fno-builtin to the library call simplifier

[Duncan Sands]

Hi Meador,

On 08/11/12 05:24, Meador Inge wrote:
> Now that the library call simplifiers are being migrated out of their own
> pass into the instruction combiner pass the latter needs to be modified to
> work with -fno-builtin.  This is accomplished by adding a new parameter
> to the InstCombiner constructor and to the createInstructionCombiningPass
> factory function that controls whether library call simplification should
> be performed or not.  The pass manager already has an option to control
> library call simplification.  This option is now passed through when creating
> instances of the instruction combiner class.

I think having this be controlled by one big all or nothing flag is a mistake.
Is there any reason not to have it query TargetLibraryInfo?

Ciao, Duncan.