[llvm-commits] [PATCH] Improve ARM build attribute emission

[David Tweed]

This isn't really an area of the code I've dived into, but it looks a
reasonable patch to me. Certainly the code needs to address the multiple new
architecture variants that now exist.

Regards,
Dave

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Amara Emerson
Sent: 02 November 2012 09:59
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [PATCH] Improve ARM build attribute emission

Hi,

The current build ARM attribute emission code isn't very complete and falls
down on some common use cases. More specifically, if you give a
-mcpu=cortex-a9 option to llc/lli with an appropriate module target triple,
then the wrong architecture build attrib is emitted (armv4t).

The attached patch fixes these cases by using the hasARCHOps() subtargets
methods to select the architecture type to emit. It also changes the default
architecture type to emit from v4t to v7 to make it consistent with codegen.

Review appreciated.

Thanks,
Amara