[llvm-commits] [PATCH] Copy clang/Driver/<Option parsing stuff> to llvm.

Daniel Dunbar daniel at zuster.org
Tue Nov 6 14:12:54 PST 2012


  The patch seems reasonable to me. What is the problem with calling tablegen for the unit test?

  One additional thing that would be nice to get since this is being imported into LLVM proper (and generalized) is at least some minimal documentation about what it is and how to use it. The unit test does a pretty reasonable job of being an example at the moment.

  How much further work do you intend to do to make this more generic and reusable? For example, the unit test has a lot of boilerplate in the way it includes the tablegen'd files that clients need to get right. Having two similar-in-spirit but totally different in implementation option handling "libraries" inside LLVM is unfortunate, so I think it is worth asking how much usability work we would need to do to, for example, use the opt table one for handling the llc/opt/etc options.

http://llvm-reviews.chandlerc.com/D102



More information about the llvm-commits mailing list