[llvm-commits] [PATCH] [CMAKE] Fix git-svn output parsing

Chandler Carruth chandlerc at google.com
Tue Nov 6 08:46:50 PST 2012


Can you describe the actual circumstances that lead to a failure and the
nature of it? Lots of us use git-svn without issue today...
On Nov 6, 2012 7:28 AM, "pravic" <ehysta at gmail.com> wrote:

> This prevents cmake fail on git-svn based repositories.
>
> http://llvm-reviews.chandlerc.com/D104
>
> Files:
>   cmake/modules/VersionFromVCS.cmake
>
> Index: cmake/modules/VersionFromVCS.cmake
> ===================================================================
> --- cmake/modules/VersionFromVCS.cmake
> +++ cmake/modules/VersionFromVCS.cmake
> @@ -28,7 +28,7 @@
>                        TIMEOUT 5
>                        RESULT_VARIABLE git_result
>                        OUTPUT_VARIABLE git_output)
> -      if( git_result EQUAL 0 )
> +      if( (git_result EQUAL 0) AND NOT (git_output STREQUAL "") )
>          string(REGEX MATCH r[0-9]+ git_svn_rev ${git_output})
>          string(LENGTH "${git_svn_rev}" rev_length)
>          math(EXPR rev_length "${rev_length}-1")
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121106/f0885575/attachment.html>


More information about the llvm-commits mailing list