[llvm-commits] Patch to add a convenience function in ELF.h

[Shankar Easwaran]

Hi Eric,
> Hi Shankar,
>
> Couple of thoughts on this:
>
> a) Use case?
You might need a symbol index from a Elf_Sym if linker needs to emit a 
Rel/Rela relocation explicitly.

> b)
>
>     Elf_Xword     st_size;  // Size of the symbol
> +
>   };
> exta whitespace
Will fix, this.
>
> c)
>
> +  return object_error::parse_failed;
>
> parse failed? Seems like an odd error.

I was looking for an error symbol_not_found, but there was only this 
which was pretty close.
>
> d)
>
> +}
> +
> +
> +template<support::endianness target_endianness, bool is64Bits>
>
> More extra whitespace.
Will fix this.

Thanks

Shankar Easwaran