[llvm-commits] [llvm] r166918 - in /llvm/trunk: include/llvm/Object/COFF.h include/llvm/Object/ELF.h include/llvm/Object/MachO.h include/llvm/Object/ObjectFile.h lib/Object/COFFObjectFile.cpp lib/Object/MachOObjectFile.cpp

[Amara Emerson]

The new interface is tested in a regression test by Tim's later commit
r166919, which uses it on ELF to extract symbol values. That was the only
kind of test that I could reasonable see for it, as there's no unit test for
libObject directly.

Amara

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: 29 October 2012 15:47
To: Chandler Carruth
Cc: llvm-commits at cs.uiuc.edu; Amara Emerson
Subject: Re: [llvm-commits] [llvm] r166918 - in /llvm/trunk:
include/llvm/Object/COFF.h include/llvm/Object/ELF.h
include/llvm/Object/MachO.h include/llvm/Object/ObjectFile.h
lib/Object/COFFObjectFile.cpp lib/Object/MachOObjectFile.cpp

On Mon, Oct 29, 2012 at 2:41 PM, Chandler Carruth <chandlerc at google.com>
wrote:
> Are there no unit tests to test new interface points of libObject?

I'll check with Amara, but there don't seem to be any unit tests for
libObject at all. Is this something we're tightening up on when
individual commits touch an area?

Tim.